Add full param options for monitors #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Seanstoppable ! If you pull 0a5d6ca your build should go green. I'll review when I've got some spare time. |
Add a more generic function that will let people mix and match Have existing functions wrap this better function Resolves the rest of state support in zorkian#164
Seanstoppable
force-pushed
the
statequery
branch
from
90e89a6 to
b701c68
Compare
|
Great, thanks @ojongerius |
ojongerius
reviewed
Oct 15, 2018
monitors.go
Outdated
| // https://docs.datadoghq.com/api/?lang=bash#get-all-monitor-details | ||
| type MonitorQueryOpts struct { | ||
| GroupStates []string | ||
| Name string |
There was a problem hiding this comment.
This should be a pointer, ie: *string
monitors.go
Outdated
| query = append(query, value) | ||
| } | ||
|
|
||
| if opts.WithDowntimes != nil { |
There was a problem hiding this comment.
Up to you but you could use the generated GetWithDownTimesOk like so:
if v, ok := opts.GetWithDowntimesOk; ok {
query = append(query, fmt.Sprintf("name=%t", strings.Join(v, ",")))
}
monitors.go
Outdated
| query = append(query, value) | ||
| } | ||
|
|
||
| if opts.Name != "" { |
There was a problem hiding this comment.
Works at the moment but needs to be changed either manually test if not nil if you refactor Name to be a pointer. Alternatively you can use the autogenereated getters and setters like so:
if v, ok := opts.GetNameOk; ok {
query = append(query, fmt.Sprintf("name=%v", strings.Join(v, ",")))
}
|
@ojongerius apologies for the delay. Updated with feedback, thanks! |
|
@Seanstoppable sorry I've been swamped with work, could you please resolve conflicts so I can merge this? |
|
Closing in favor of #199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a more generic function that will let people mix and match
Have existing functions wrap this better function
Resolves the rest of state support in #164