Add several options to Monitor parameter #201
Merged
+630
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kterada0509 could you expend on why this is marked WIP, did you plan to do more work? |
teraken0509
changed the title
|
@ojongerius nothing. just i think should be waited for documents update. |
|
LGTM 👍 would you mind rebasing this PR @kterada0509 ? |
teraken0509
force-pushed
the
feature/add-monitor-unsupported-params
branch
from
e0d65e8 to
261f8a8
Compare
|
Thanks for the rebase! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
FIxed #200
Abstract
Just added unsupported params.