[dashboards] Support getting dashboards by string id #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLaureB
reviewed
Mar 20, 2019
helpers.go
Outdated
| @@ -79,3 +83,18 @@ func GetPrecision(v *PrecisionT) (PrecisionT, bool) { | |||
|
|
|||
| return PrecisionT(""), false | |||
| } | |||
|
|
|||
| // GetStringId is a helper routine that allows screenboards and timebaords to be retrieved | |||
There was a problem hiding this comment.
Small typo: timebaords -> timeboards
integration/dashboards_test.go
Outdated
| if err != nil { | ||
| t.Fatalf("Retrieving a dashboard failed when it shouldn't. (%s)", err) | ||
| } | ||
| assertDashboardEquals(t, actual, expected) |
There was a problem hiding this comment.
We could also test that Id and NewId are the same (between the 2 objects returned by CreateDashboard).
MLaureB
approved these changes
Mar 21, 2019
|
LGTM 👍. @enbashi are you ok with me squashing all the commits when merging? |
|
Cool, thank you very much! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to use the new dashboard string ID format in
GetScreenboard()andGetDashboard().Used in https://github.com/terraform-providers/terraform-provider-datadog/pull/165