Support for /v1/synthetics #228
Conversation
|
Please ping me before merging, as we are about to bump the version of the API, so I might still add a few commits today |
|
Really looking forward to this coming in and unblocking Terraform support for Synthetics 👏 |
|
@ojongerius Thanks! As you can see from a few recent PRs were generally looking to get more involved in the project. Let us know if theres anyway we (the Datadog team) can help with on going development. |
btoueg
force-pushed
the
synthetics_checks
branch
3 times, most recently
from
f1b3a8e to
fde6f59
Compare
btoueg
force-pushed
the
synthetics_checks
branch
from
97b8af2 to
2e0b696
Compare
|
Awesome @irabinovitch! @btoueg let me know when you are happy for me to merge. |
|
Hi @ojongerius, this PR is good to go, thanks! |
|
@btoueg would you mind squashing the commits a little bit? For example, commit [1] only adds a TODO line, which is AFAICS then removed in another commit. This is relevant in terms of how this PR evolved, but not relevant to the history of the project when this gets merged. I wouldn't actually mind if this whole PR was a single commit, as it brings in a new functionality as a whole and doesn't interact much with the rest of the codebase. [1] cf85f6a |
|
Squash merge option should make it trivial https://github.blog/2016-04-01-squash-your-commits/ but I'll do it in case you don't have access to this functionality |
btoueg
force-pushed
the
synthetics_checks
branch
from
ec066ec to
7dad6b0
Compare
|
@btoueg interesting, I wasn't aware that was possible :) Either way, I don't have rights to merge (yet, should get them in couple of days) so ATM I'm just expressing my opinion. Thanks! |
|
Gonna add one commit today |
btoueg
force-pushed
the
synthetics_checks
branch
from
29e47c2 to
d9e52ea
Compare
|
@bkabrda @ojongerius Is it possible to merge it ASAP? |
|
No further comments from anyone here, the PR looks solid. I'm going to merge it. Thanks! 👍 |
Follow up on #205