Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Add support for log, apm and process query in legacy API #251

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

jbenais
Copy link
Contributor

@jbenais jbenais commented Jul 16, 2019

This PR adds support for log_query, apm_query and process_query in legacy screenboards and timeboards API.

Datadog JSON sample

{
  "requests": [
    {
      "log_query": {
        "index": "main",
        "search": {
          "query": "service:my-app AND status:error"
        },
        "groupBy": [],
        "compute": {
          "aggregation": "count",
          "facet": null,
          "interval": "300000"
        }
      },
      "aggregator": "count",
      "style": {
        "palette": "warm",
        "type": "solid",
        "width": "thick"
      },
      "type": "line",
      "conditional_formats": []
    }
  ],
  "viz": "timeseries",
  "autoscale": true,
  "yaxis": {
    "scale": "log",
    "includeZero": false
  },
  "status": "done"
}

@jbenais jbenais force-pushed the julia/log-query-legacy-api branch from 70312ca to 1bd777c Compare July 16, 2019 21:36
dashboards.go Outdated Show resolved Hide resolved
screen_widgets.go Outdated Show resolved Hide resolved
@jbenais jbenais force-pushed the julia/log-query-legacy-api branch 4 times, most recently from 44c6e2e to 27a5923 Compare July 22, 2019 20:24
@jbenais jbenais changed the title [dashboard] Add support for log query in legacy API [dashboard] Add support for log, apm and process query in legacy API Jul 22, 2019
@jbenais jbenais force-pushed the julia/log-query-legacy-api branch from 27a5923 to 1278834 Compare July 23, 2019 13:17
Copy link
Contributor

@enbashi enbashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jbenais jbenais force-pushed the julia/log-query-legacy-api branch from 1278834 to 511b7c4 Compare July 23, 2019 16:01
@bkabrda
Copy link
Collaborator

bkabrda commented Jul 29, 2019

The code is clean and the tests are passing. I have no objections here. Good work 👍 , I'm merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants