-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[slos] fix API payloads #252
Conversation
The recent changes have removed the |
yup! I'm waiting for us to merge && deploy the final API changes before continuing this work 👌 |
@platinummonkey ok, feel free to ping me whenever this is ready to be re-reviewed. |
@bkabrda good to go 👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I just have one question in comment inline. Once that's clear, I can go forward and merge this.
@@ -34,32 +35,38 @@ func TestServiceLevelObjectivesCreateGetUpdateAndDelete(t *testing.T) { | |||
assert.Equal(t, expected.Description, actual.Description) | |||
assert.True(t, expected.Thresholds.Equal(actual.Thresholds)) | |||
|
|||
time.Sleep(time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the sleep? Is it expected that the SLO object is not available through API immediately? Or is it available but incomplete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that in a few rare cases, the read replicas were behind just enough to make this fail without some artificial delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for the explanation.
LGTM now, merging. Thanks! |
We changed the name of this the threshold
slo
property totarget
as it's more meaningful. The hardest part of SW - naming.Also updated the content types of create and added request validation as well.