Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get all dashboards support (New dashboards API) #255

Merged
merged 1 commit into from
Aug 2, 2019
Merged

feat: add get all dashboards support (New dashboards API) #255

merged 1 commit into from
Aug 2, 2019

Conversation

Morsicus
Copy link
Contributor

@Morsicus Morsicus commented Aug 1, 2019

Features

Copy link
Collaborator

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great, I just left two comments inside to get fixed. Thanks for submitting the PR!

boards.go Outdated Show resolved Hide resolved
boards.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, merging. Thanks a lot for the PR!

@bkabrda bkabrda merged commit d0ce49a into zorkian:master Aug 2, 2019
jbenais pushed a commit to jbenais/go-datadog-api that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/v1/dashboard to get all dashboards is missing
2 participants