Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard widget] Add table widget #258

Merged
merged 13 commits into from
Aug 12, 2019

Conversation

mhintz
Copy link
Contributor

@mhintz mhintz commented Aug 8, 2019

Datadog recently released a new Table widget type on dashboards. This PR adds the definition format for this widget to the Go API

Depends on #257

@bkabrda
Copy link
Collaborator

bkabrda commented Aug 12, 2019

@mhintz this PR looks good, but you'll need to run make generate and commit datadog-accessors.go to generate all the necessary accessors and make CI pass. I can merge when that's done.

@bkabrda
Copy link
Collaborator

bkabrda commented Aug 12, 2019

LGTM now, merging. Thanks for the contribution!

@bkabrda bkabrda merged commit 09fd0fd into zorkian:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants