Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hosts total #267

Merged
merged 6 commits into from
Sep 13, 2019
Merged

Conversation

dabcoder
Copy link
Contributor

Follow up of #215.

@dabcoder dabcoder force-pushed the davidb/hosts-total-contributor branch from 5574d36 to f9bff1b Compare August 23, 2019 16:06
This was referenced Aug 23, 2019
Copy link
Collaborator

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit to fix, otherwise LGTM 👍

hosts.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the PR! Merging.

@bkabrda bkabrda merged commit 9369b04 into zorkian:master Sep 13, 2019
@dabcoder dabcoder deleted the davidb/hosts-total-contributor branch September 13, 2019 11:37
@dabcoder
Copy link
Contributor Author

Thanks for the contribution too @dharada1

@bkabrda bkabrda mentioned this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants