Add GetMonitorsByMonitorTags function #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behaviour was being able to fetch monitors using the custom tags assigned to a monitor which the API calls "monitor_tags". I think quite rightly this was defined explicitly in the MonitorQueryOpts type, but we lost the function to be able to fetch monitors based upon those tags when this was added in[2]. Add a function back to enable me to fetch these monitors using those custom tags again. [1] https://docs.datadoghq.com/api/?lang=bash#get-all-monitor-details [2] e0e1131
platinummonkey
approved these changes
Oct 7, 2019
bkabrda
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behaviour was being able to fetch monitors using the custom tags assigned to a monitor which the API calls "monitor_tags".
I think quite rightly this was defined explicitly in the MonitorQueryOpts type, but we lost the function to be able to fetch monitors based upon those tags when this was added in[2].
Add a function back to enable me to fetch these monitors using those custom tags again.
[1] https://docs.datadoghq.com/api/?lang=bash#get-all-monitor-details
[2] e0e1131