Update AWS integration endpoints #274
Conversation
| return false | ||
| } | ||
|
|
||
| // SetLambdaARN allocates a new i.LambdaARN and returns the pointer to it. |
There was a problem hiding this comment.
Doesn't allocate anything nor return anything.
| // SetLambdaARN allocates a new i.LambdaARN and returns the pointer to it. | |
| // SetLambdaARN set LambdaARN to point to the given string. |
| return false | ||
| } | ||
|
|
||
| // SetAccountID allocates a new i.AccountID and returns the pointer to it. |
There was a problem hiding this comment.
Doesn't allocate anything nor return anything.
| // SetAccountID allocates a new i.AccountID and returns the pointer to it. | |
| // SetAccountID set AccountID to point to the given string. |
| return false | ||
| } | ||
|
|
||
| // SetLambdaARN allocates a new i.LambdaARN and returns the pointer to it. |
There was a problem hiding this comment.
Doesn't allocate anything nor return anything.
| // SetLambdaARN allocates a new i.LambdaARN and returns the pointer to it. | |
| // SetLambdaARN set LambdaARN to point to the given string. |
| return false | ||
| } | ||
|
|
||
| // SetAccountID allocates a new i.AccountID and returns the pointer to it. |
There was a problem hiding this comment.
Doesn't allocate anything nor return anything.
| // SetAccountID allocates a new i.AccountID and returns the pointer to it. | |
| // SetAccountID set AccountID to point to the given string. |
| return false | ||
| } | ||
|
|
||
| // SetAccountID allocates a new i.AccountID and returns the pointer to it. |
There was a problem hiding this comment.
Doesn't allocate anything nor return anything.
| // SetAccountID allocates a new i.AccountID and returns the pointer to it. | |
| // SetAccountID set AccountID to point to the given string. |
There was a problem hiding this comment.
The integrations.go file is starting to be crowded.
Could we use a Facade pattern to delegate service integrations to their own files? I am not sure if we can do so without breaking backward compatibility.
Also, maybe we should add unit tests to make sure object struct match jsons returned by the API.
this was generated by the command |
|
Okay since this is all autogenerated, changing this is not for the scope of this PR IMO. |
Indeed, you're right. Thank you for the review |
Add a few missing AWS integration endpoints