Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Level Objectives - Check Can Delete && History Endpoints #278

Merged
merged 6 commits into from
Oct 30, 2019
Merged

Service Level Objectives - Check Can Delete && History Endpoints #278

merged 6 commits into from
Oct 30, 2019

Conversation

platinummonkey
Copy link
Contributor

@platinummonkey platinummonkey commented Oct 24, 2019 •
edited
Loading

Adds 2 additional SLO endpoints

I specifically didn't write integration tests as:

  1. check can delete requires a dashboard to be created then an SLO created then a widget added to that dashboard (this seems like a very brittle test)
  2. history - depends on data being available in the test environment to properly execute and test. I'm not aware of any stable test data for use in the integration org

zippolyte
zippolyte requested changes Oct 29, 2019
View reviewed changes
Copy link
Collaborator

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apparat from those two minor comments

service_level_objectives.go Outdated Show resolved Hide resolved
service_level_objectives.go Outdated Show resolved Hide resolved
zippolyte
zippolyte approved these changes Oct 29, 2019
View reviewed changes
Copy link
Collaborator

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkabrda good to merge !

bkabrda
bkabrda approved these changes Oct 30, 2019
View reviewed changes
Copy link
Collaborator

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thanks!

@bkabrda bkabrda merged commit 9881eb2 into zorkian:master Oct 30, 2019
kazz187 pushed a commit to kazz187/go-datadog-api that referenced this pull request Nov 28, 2019
@platinummonkey @kazz187
Service Level Objectives - Check Can Delete && History Endpoints (zor…
19179af 
…kian#278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zippolyte zippolyte zippolyte approved these changes

@bkabrda bkabrda bkabrda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@platinummonkey @bkabrda @zippolyte