Update GCP integration

[mzneos]

What does this PR do?

• Adds the field AutoMute to the IntegrationGCPCreateRequest object.
• Updates the IntegrationGCP object
• Refactors the UpdateIntegrationGCP function as it was not working anymore (the endpoints does not seem to work)
  • for backward compatibility, the IntegrationGCPUpdateRequest object was just updated instead of using the already existing IntegrationGCPCreateRequest object, which is identical
• Updates the integration/integration_test.go tests functions for the GCP integration, adding checks for the AutoMute field

[gzussa]

I double checked omitempty. Seems backward compatible. Please do test this manually before to merge it.

[bkabrda]

Hey, thanks for sending this PR. The code looks good, but I'd like to ask you to extend the test TestIntegrationGCPUpdate in integration/integration_test.go. It'd be awesome if that tested most (or ideally all) of the structure fields of IntegrationGCPUpdateRequest.

[mzneos]

Hey, thanks for sending this PR. The code looks good, but I'd like to ask you to extend the test TestIntegrationGCPUpdate in integration/integration_test.go. It'd be awesome if that tested most (or ideally all) of the structure fields of IntegrationGCPUpdateRequest.

Yes of course, I can do that. I'll look into it as soon as I have some time.

[mzneos]

I think the tests should be ok now. I also updated the test for TestIntegrationGCPCreateAndDelete to check the new AutoMute field added.
All the fields returned by ListIntegrationGCP are tested now, in both functions

[bkabrda]

I'm getting the following failure:

=== RUN   TestIntegrationGCPUpdate
--- FAIL: TestIntegrationGCPUpdate (4.80s)
    integrations_test.go:431: Retrieving a GCP integration failed when it shouldn't: json: cannot unmarshal bool into Go struct field IntegrationGCP.automute of type string

It seems that you provided type *string for IntegrationGCP.AutoMute, but it should be *bool.

[mzneos]

Indeed there was a typo in the IntegrationGCP struct. Thank you for spotting that!
The tests should succeed now

[bkabrda]

Perfect, LGTM now => merging. Thank you very much for this contribution!