[logs_processors] Add support for lookup processors #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blemale
force-pushed
the
logs_processors_add_lookup_processor
branch
from
44bf87a to
c0c23af
Compare
|
Hi @bkabrda ! Could you have your 👀 on this PR? |
bkabrda
requested changes
Nov 22, 2019
| @@ -93,6 +94,14 @@ type GrokRule struct { | |||
| MatchRules *string `json:"match_rules"` | |||
| } | |||
|
|
|||
| // LookupProcessor represents the lookup processor from config API. | |||
| type LookupProcessor struct { | |||
| Source *string `json:"source"` | |||
There was a problem hiding this comment.
The fields that are not required should be marked as omitempty (IIUC that's default_lookup)
There was a problem hiding this comment.
You're right! I have made the change 👌
bkabrda
approved these changes
Nov 22, 2019
kazz187
pushed a commit
to kazz187/go-datadog-api
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for lookup processors, see https://docs.datadoghq.com/logs/processing/processors/?tab=ui#lookup-processor