Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support interval field on metrics POST #288

Merged
merged 3 commits into from
Jan 17, 2020
Merged

Support interval field on metrics POST #288

merged 3 commits into from
Jan 17, 2020

Conversation

justiniso
Copy link
Contributor

Adds support for submitting the interval for metrics, which is supported by the API.

@justiniso
Copy link
Contributor Author

Bump, any reasons not to merge this?

@justiniso
Copy link
Contributor Author

@bkabrda @gzussa either of you mind having a look?

bkabrda
bkabrda approved these changes Jan 17, 2020
View reviewed changes
Copy link
Collaborator

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution. Merging.

@bkabrda bkabrda merged commit c39e0b3 into zorkian:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkabrda bkabrda bkabrda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justiniso @bkabrda