Add methods to retrieve logs from logs-queries/list API endpoint #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, I should probably link to the API doc: https://docs.datadoghq.com/api/?lang=bash#get-a-list-of-logs |
|
@sendqueery Thank you for the PR. We have a few folks at Datadog reviewing. |
xvello
reviewed
Jan 6, 2020
There was a problem hiding this comment.
Hello @sendqueery and thank you for the PR!
I am with the Logs Management team and here are my comments on the business-logic side. Please don't hesitate to @ me if you have questions on my comments.
I'll get someone more familiar with the repo to also review the testing, documentation and code style.
sendqueery
force-pushed
the
log-queries-list
branch
from
1b59a2b to
eb7fef4
Compare
bkabrda
requested changes
Jan 7, 2020
sendqueery
force-pushed
the
log-queries-list
branch
from
a2c6dea to
89b23c4
Compare
|
@bkabrda I also changed the naming of |
bkabrda
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datadog web interface only allows a user to export up to 5k log lines at a time. Sometimes, you just need more than that. This PR adds functionality that allows a user to hit the
logs-queries/listAPI and retrieve any number of logs, along with the corresponding tags and attributes for each.As this particular API only returns up to 1000 lines at a time,
GetLogsListPages()handles the pagination and can retrieve all results.This has appropriate tests and mock JSON response data, and has been successfully tested for use in a small scraper tool I'm writing for internal use at work.