-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YouTube: Some fields not found when run from translation-server #3290
Comments
The YouTube translator uses scraping for some fields because of this: Lines 101 to 103 in 7837c42
But when run from translation-server we only have the JSON-LD. So maybe we need to check whether the page is actually built and fall back to JSON-LD for all fields if not. |
@dstillman Upon further testing, I've found that the translation-server can only get the useless BreadcrumbList JSON-LD and not the VideoObject one the translator uses. However, it seems to get Also, is there a way to see the HTML retrieved by translation-server? It would make debugging this much easier. |
Probably, but we would have to make sure it was only using the meta tags for over-the-wire saves and never using them for Connector-based saves, due to the problem explained in the comment. So we'd have to make sure we were detecting that properly.
Yes, you can add |
When parsing a YouTube URL, the server attempts to use the YouTube translator, but ultimately skips it because it fails to read the title with the below error:
These lines in the translator are responsible for parsing the title:
translators/YouTube.js
Lines 106 to 108 in 7837c42
The titles are read in properly in both in Scaffold and the Zotero desktop client, so this seems to be an issue with the translation server.
The text was updated successfully, but these errors were encountered: