YouTube: Fix missing fields when run from translation-server #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbeJellinek
requested changes
Apr 2, 2024
There was a problem hiding this comment.
- I think we can get all this data from page
<meta>tags. Title is in<meta name="title">, description is in<meta name="description">, duration is in<meta itemprop="duration">, etc. - We should not use any of these fallbacks if we aren't on the server (
Zotero.isServer), because they won't change as you browse around the site and navigate to other videos in the mobile/desktop SPA.
| let jsonLD; | ||
| try { | ||
| jsonLD = JSON.parse(text(doc, 'script[type="application/ld+json"]')); | ||
| } | ||
|
|
@AbeJellinek |
|
I think it's alright if it's just on the server. Not ideal, but parsing the microformat is way messier, slower (because of the global regex search), and more prone to breakage. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3290 by adding an extra fallback for Title, runningTime, Date, Duration, and Description fields based on a regex search for the microformat object, which can be found in the HTML regardless if the page's JS is loaded.