Zenodo -> InvenioRDM, support more repositories #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborel
force-pushed
the
zenodo2023
branch
2 times, most recently
from
e25d490 to
e2314ca
Compare
|
I can't see why the checks are failing. The log says "Some translator tests failed", but on my systems all tests look OK. Is it possible to run the exact same checks locally, and hopefully get more explicit error messages? |
aborel
force-pushed
the
zenodo2023
branch
2 times, most recently
from
967fcf7 to
dc1632e
Compare
AbeJellinek
requested changes
Jan 22, 2024
|
OK, a few comments. More generally, though, do we actually need two translators here? The changes seem very minimal. |
|
Thanks @AbeJellinek for your comments. I'll see if I can assemble both repository families into one single translator. |
|
Not ready yet. |
aborel
force-pushed
the
zenodo2023
branch
4 times, most recently
from
bc5dc01 to
39e4031
Compare
|
OK, ready for another round of review :-) |
- More straightforward path check in detectWeb - Add setTranslator() label comment - Set libraryCatalog to Zenodo when scraping Zenodo.org for clarity and consistency with old translator
AbeJellinek
force-pushed
the
zenodo2023
branch
2 times, most recently
from
d721238 to
230a6e5
Compare
AbeJellinek
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #3057 .
Extending the Zenodo translator to support several InvenioRDM repositories that have been identified
Quick fix for tags that were not retrieved properly in the previous version
Recycling the previous Zenodo translator to support various repositories based on the former Zenodo code base