Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Theia integration tests #2979

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Fix Theia integration tests #2979

merged 6 commits into from
Jun 27, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Jun 26, 2024

Proposed changes

Fixes #2977 by updating element IDs in tests.

Also updates workflow to use new VSCE directory supported by Theia (see eclipse-theia/theia#13178).

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

This PR is probably a good candidate to be squash merged 😋

@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Jun 26, 2024
@t1m0thyj t1m0thyj added this to the v2.17.0 milestone Jun 26, 2024
@t1m0thyj t1m0thyj linked an issue Jun 26, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Jun 26, 2024

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (eeb6c06) to head (08daa39).
Report is 2 commits behind head on maintenance.

Additional details and impacted files
@@             Coverage Diff              @@
##           maintenance    #2979   +/-   ##
============================================
  Coverage        93.49%   93.49%           
============================================
  Files              104      104           
  Lines            10845    10845           
  Branches          2262     2353   +91     
============================================
  Hits             10139    10139           
  Misses             705      705           
  Partials             1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @t1m0thyj 😋 LGTM!

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @t1m0thyj

@JillieBeanSim JillieBeanSim merged commit d7badfa into maintenance Jun 27, 2024
20 checks passed
@JillieBeanSim JillieBeanSim deleted the ci/fix-theia-tests branch June 27, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests failing after updating Theia to 1.49
3 participants