[Bug] zulip_bots does not include importlib-metadata as a dependency on Python>=3.10 but tries to import it regardless of version #829
Assignees
Labels
Comments
|
Hi @cauebs @timabbott , Can I work on this issue? |
|
Yep, please do! |
27piyus
added a commit
to 27piyus/python-zulip-api
that referenced
this issue
Nov 28, 2024
Hopefully, this will help improve the quality of new-contirbutor pull requests to this project. <!-- Describe your pull request here.--> This pull request addresses the issue with the importlib-metadata dependency in the zulip_bots project. The dependency was missing for Python >= 3.10, causing import errors. I have updated the setup.py file to ensure that the importlib-metadata package is conditionally included for Python versions < 3.10, ensuring compatibility. Fixes: <!-- Issue link, or clear description.--> This PR fixes the issue zulip#829, where importlib_metadata was being imported in Python >= 3.10 without being listed as a required dependency. <!-- If the PR changes output, always include screenshots or code blocks to demonstrate your changes. If it seems helpful, add a screen capture of the new functionality as well. Tooling tips: https://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html --> No visual changes were made. The functionality was tested by running the bot with Python 3.10, and the error no longer occurs. <details> <summary>Self-review checklist</summary> <!-- Prior to submitting a PR, follow our step-by-step guide to review your own code: https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#how-to-review-code --> <!-- Once you create the PR, check off all the steps below that you have completed. If any of these steps are not relevant or you have not completed, leave them unchecked.--> - [ ] [Self-reviewed](https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#how-to-review-code) the changes for clarity and maintainability (variable names, code reuse, readability, etc.). Communicate decisions, questions, and potential concerns. - [ ] Explains differences from previous plans (e.g., issue description). - [ ] Highlights technical choices and bugs encountered. - [ ] Calls out remaining decisions and concerns. - [ ] Automated tests verify logic where appropriate. Individual commits are ready for review (see [commit discipline](https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html)). - [ ] Each commit is a coherent idea. - [ ] Commit message(s) explain reasoning and motivation for changes. Completed manual review and testing of the following: - [ ] Visual appearance of the changes. - [ ] Responsiveness and internationalization. - [ ] Strings and tooltips. - [ ] End-to-end functionality of buttons, interactions and flows. - [ ] Corner cases, error conditions, and easily imagined bugs. </details>
|
@zulipbot claim |
|
@27piyus This issue cannot be claimed, as someone else is already working on it. Please see our contributor guide for advice on finding an issue to work on. Thanks! |
|
@timabbott can you please tell me why is there issue in checking as i already solved the issue |
Niloth-p
added a commit
to Niloth-p/python-zulip-api
that referenced
this issue
Dec 4, 2024
Use `importlib-metadata` for newer Python versions as well. Fixes zulip#829.
12 tasks
|
having this error as well, making the setup not quite usable, please check again |
timabbott
pushed a commit
that referenced
this issue
Dec 5, 2024
Use `importlib-metadata` for newer Python versions as well. Fixes #829.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running on Python 3.10:
Solution is to either always include
importlib-metadataas a dependency inzulip_bots/setup.py, independently of the Python version, or do a conditional import checking for the Python version and using std'simportlib.metadatainstead ofimportlib_metadatafor Python>=3.10.Whichever the maintainers decide, I can file a pull request for it.
The text was updated successfully, but these errors were encountered: