Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: SSL on IRC connection #629

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

benjaoming
Copy link

I thought this would be easy -- but so far, it has just been a rabbit hole of sorts.

So I'm posing my current results.

#496

Issues:

  • Messages are not forwarded from Zulip=>IRC, the connection breaks and we get:

    irc_mirror_zulip has left the room (Quit: Read error: error:1408F119:SSL routines:ssl3_get_record:decryption failed or bad record mac).

  • No scheduler object, so reconnections aren't scheduled and the whole bridge dies

@PIG208
Copy link
Member

PIG208 commented Jun 14, 2021

Hi @benjaoming, are you still interested in working this?

@benjaoming
Copy link
Author

@PIG208 - I would be happy to comment/review on any work extending on this, but realistically I don't have time to finish it. I don't think there's anything in this PR that couldn't be taken further.

I'll try to ask around if anyone would be interested in picking it up.

@zulipbot
Copy link
Member

Heads up @benjaoming, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

@benjaoming
Copy link
Author

This PR is now updated with the conflicts caused by black linting.

@zulipbot
Copy link
Member

Heads up @benjaoming, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants