Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update game_handler.py #641

Closed
wants to merge 1 commit into from
Closed

Update game_handler.py #641

wants to merge 1 commit into from

Conversation

vinitwadgaonkar
Copy link
Collaborator

tried changing !avatar tag to html

@vinitwadgaonkar
Copy link
Collaborator Author

this is for #632

@vinitwadgaonkar vinitwadgaonkar mentioned this pull request Jan 7, 2021
Open
@vinitwadgaonkar
Copy link
Collaborator Author

@neiljp sir please review

@timabbott
Copy link
Member

Thanks for working on this! I don't understand these changes, and in particular I don't think they'll work -- you're trying to add HTML tags that aren't allowed in Zulip's markdown implementation.

I'll add that one of the most important things to do when contributing to an open source project (or software development in general) is writing commit messages that explain why your changes are correct.

Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

@timabbott timabbott closed this Jan 26, 2021
@timabbott timabbott mentioned this pull request Jan 26, 2021
Closed
@vinitwadgaonkar
Copy link
Collaborator Author

vinitwadgaonkar commented Jan 27, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinitwadgaonkar @timabbott @zulipbot