Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding fetch_upload method to client #678

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding fetch_upload method to client #678

wants to merge 2 commits into from

Conversation

Ponni-M
Copy link

@Ponni-M Ponni-M commented Apr 18, 2021

@timabbott timabbott requested a review from LoopThrough-i-j May 24, 2021 21:32
@timabbott
Copy link
Member

@Ponni-M can you restructure the commits to first refactor the /api/ prefix stuff, with a commit message explaining why that's correct, and then one adding the new endpoint?

Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

LoopThrough-i-j
LoopThrough-i-j reviewed May 25, 2021
View reviewed changes
zulip/zulip/__init__.py
effective_url = API_VERSTRING + effective_url
accesswithAPI = True
return self.do_api_query(marshalled_request, effective_url, method=method,
longpolling=longpolling, files=files, timeout=timeout, accesswithAPI = accesswithAPI)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think accesswithAPI = accessVersionedAPI makes more sense, we don't need a separate variable accesswithAPI.

@LoopThrough-i-j
Copy link
Contributor

LoopThrough-i-j commented May 25, 2021 •
edited
Loading

@Ponni-M thanks for working on this, added a comment.
Everything else LGTM.

@zulipbot
Copy link
Member

Heads up @Ponni-M, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoopThrough-i-j LoopThrough-i-j LoopThrough-i-j left review comments

Assignees
No one assigned
Labels
has conflicts size: M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ponni-M @timabbott @LoopThrough-i-j @zulipbot