Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rss-bot: Handle feed entries that lack a title field. #837

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

Niloth-p
Copy link
Contributor

@Niloth-p Niloth-p commented Nov 1, 2024

Fixes #836.

Mastodon feed entries do not have a 'title' field.

We could handle this

  • by not displaying the title, or
  • by displaying the description as the title (truncated to a constant value)

This PR implements the former approach.

Screenshots

Screenshots

No Title (former approach)
No title

Truncated Description - 60 characters (latter approach)
Truncated title

@timabbott timabbott merged commit fb73220 into zulip:main Nov 1, 2024
12 of 13 checks passed
@timabbott
Copy link
Member

This seems pretty reasonable, merged, thanks @Niloth-p!

@Niloth-p Niloth-p deleted the rss-mastodon branch November 2, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mastodon broken in RSSBot
3 participants