Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocomplete: Support wildcard @-mentions #234

Closed
chrisbobbe opened this issue Jul 21, 2023 · 0 comments · Fixed by #889
Closed

autocomplete: Support wildcard @-mentions #234

chrisbobbe opened this issue Jul 21, 2023 · 0 comments · Fixed by #889
Assignees
@sm-sayedi
Labels
a-compose Compose box, autocomplete, attaching files/images
Milestone
M5-a: Server 10

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Jul 21, 2023 •
edited
Loading

With #207 being merged, we now have an @-mention autocomplete UI for user mentions! 🎉

We should extend it to support autocompleting wildcard mentions, like @**all** and @**channel**.

The exact set of wildcard-mention options will depend on the server version:
@chrisbobbe chrisbobbe added the a-compose Compose box, autocomplete, attaching files/images label Jul 21, 2023
@chrisbobbe chrisbobbe added this to the Launch milestone Jul 21, 2023
@gnprice gnprice mentioned this issue Apr 24, 2024
Closed
@gnprice gnprice modified the milestones: Launch, B2: Summer 2024 May 9, 2024
@gnprice gnprice mentioned this issue Jul 16, 2024
Closed
@sm-sayedi sm-sayedi self-assigned this Aug 14, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 16, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
76fd1ac 
Fixes: zulip#234
@sm-sayedi sm-sayedi mentioned this issue Aug 16, 2024
Merged
This was referenced Aug 19, 2024
Closed
Open
Merged
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 22, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
1664a2d 
Fixes: zulip#234
gnprice pushed a commit to sm-sayedi/zulip-flutter that referenced this issue Nov 8, 2024
@sm-sayedi @gnprice
autocomplete: Support @-wildcard in user-mention autocomplete
a24bddb 
Fixes: zulip#234
@gnprice gnprice modified the milestones: Beta 3: Summer 2024, Launch Nov 21, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 3, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
33fb50f 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 3, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
d278e34 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 3, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
6478559 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 6, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
078194e 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 6, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
b0a6651 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 6, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
a0ab0ed 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 6, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
0b3bc6c 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 6, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
9c80cb0 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 6, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
e873ea4 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 9, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
0af384f 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 9, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
06918d3 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 10, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
a1bd8b5 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 10, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
08789d6 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Dec 14, 2024
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
ee45cde 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 12, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
55c36c4 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 12, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
c21fe24 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
@gnprice gnprice modified the milestones: M5: Launch, M5-a: Server 10 Jan 14, 2025
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 15, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
0b864f2 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 19, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
9d2d7bc 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 19, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
65a2ab7 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 22, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
21568dc 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 24, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
4ee0096 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 26, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
41dc1a4 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 26, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
4e59600 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 29, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
afaa43d 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 30, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
7ca409a 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jan 30, 2025
@sm-sayedi
autocomplete: Support @-wildcard in user-mention autocomplete
826a5a2 
The implementation logic is similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js

Fixes: zulip#234
rishichirchi pushed a commit to rishichirchi/zulip-flutter that referenced this issue Feb 7, 2025
@sm-sayedi @rishichirchi
autocomplete: Support @-wildcard in user-mention autocomplete
eb5b151 
The implementation logic is mostly similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js#L92-L141

It is different from the zulip-mobile in the following ways:
  - suppress wildcards on silent mentions
  - match "stream" queries even on new servers (but emit @**channel**)

Fixes: zulip#234
github-actions bot pushed a commit that referenced this issue Feb 12, 2025
@sm-sayedi @github-actions
autocomplete: Support @-wildcard in user-mention autocomplete
e41487b 
The implementation logic is mostly similar to the zulip-mobile implementation:
  https://github.com/zulip/zulip-mobile/blob/a115df1f71c9dc31e9b41060a8d57b51c017d786/src/autocomplete/WildcardMentionItem.js#L92-L141

It is different from the zulip-mobile in the following ways:
  - suppress wildcards on silent mentions
  - match "stream" queries even on new servers (but emit @**channel**)

Fixes: #234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sm-sayedi sm-sayedi

Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Flutter app
Status: Done
Milestone
M5-a: Server 10
Development

Successfully merging a pull request may close this issue.

autocomplete: Support @-wildcard in user-mention autocomplete sm-sayedi/zulip-flutter
3 participants
@gnprice @chrisbobbe @sm-sayedi