Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct Message [Action Sheet]: add Action sheet for a DM conversation #1334

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abhisheksainii
Copy link

Fixes #1272

In this PR, I added the option to open an action sheet for a DM that does 2 things :

  1. Mark all messages as read for that DM.
  2. Gives the ability to view the members in a group DM.

The action sheet can be opened through 4 different locations:

  1. A DM row in the Inbox
  2. A recipient header in the message list
  3. The area of the message-list app bar that identifies the narrow
  4. The "Direct messages" page

The steps I followed to implement the above:

  1. Constructed a DM action sheet class by extending it from ActionSheet abstract class.
  2. Built DM users page (Figma design) with the ability to search for the users in the list.
  3. made use of enums to highlight the sheet option, i.e, either mark messages are read or view group DM users.

Attaching screenshots for reference.
WhatsApp Image 2025-02-06 at 17 16 59 (1)
WhatsApp Image 2025-02-06 at 17 16 59 (2)
WhatsApp Image 2025-02-06 at 17 16 59
WhatsApp Image 2025-02-06 at 17 17 00 (1)
WhatsApp Image 2025-02-06 at 17 17 00 (2)
WhatsApp Image 2025-02-06 at 17 17 00
WhatsApp Image 2025-02-06 at 17 17 01

WhatsApp.Video.2025-02-06.at.00.51.08.mp4

@Abhisheksainii Abhisheksainii marked this pull request as draft February 6, 2025 12:45
@Abhisheksainii Abhisheksainii marked this pull request as ready for review February 6, 2025 18:31
@chrisbobbe
Copy link
Collaborator

Thanks @Abhisheksainii for your work on this!

Given that this issue is for the M6 Post-launch milestone, and that this PR doesn't yet have tests so still has significant work ahead before we can merge it, let's put it on hold for now until the launch is ready — see announcement.

@chrisbobbe chrisbobbe added this to the M6: Post-launch milestone Feb 6, 2025
@chrisbobbe chrisbobbe marked this pull request as draft February 6, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action sheet for a DM conversation
2 participants