Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1339: Fix large exponent issue in BackoffMachine by tracking backoff incrementally #1352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

suraj-aayush
Copy link

@suraj-aayush suraj-aayush commented Feb 13, 2025

Fixes incorrect backoff logic – Now, _currentBound correctly increases exponentially.
Prevents exceeding maxBound – Ensures we don’t wait longer than necessary.
Improves reliability – Makes sure backoff logic works consistently across retries.

Fixes: #1339

@gnprice
Copy link
Member

gnprice commented Feb 13, 2025

Hi, welcome.

Before we can review this, it will need tests, and it will need to be a clean Git commit without extraneous changes. For both those points, see our README for details and links to further resources.

@PIG208 PIG208 added this to the M6: Post-launch milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid large exponents in BackoffMachine
3 participants