Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote and reply does not quote LaTeX correctly #5849

Closed
varkor opened this issue Apr 4, 2024 · 0 comments · Fixed by #5851
Closed

Quote and reply does not quote LaTeX correctly #5849

varkor opened this issue Apr 4, 2024 · 0 comments · Fixed by #5851
Assignees
@chrisbobbe

Comments

@varkor
Copy link

varkor commented Apr 4, 2024

If you use the "Quote and reply" option on a message with some LaTeX in, i.e. text surrounded by double dollar signs (e.g. $$expression$$), the LaTeX in the quoted message only has single dollar signs around the expressions (e.g. $expression$), which causes it not to be rendered correctly.
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 6, 2024
@chrisbobbe
compose: Fix breakage of LaTeX delimiters in quote-and-reply
751a9ec 
String.prototype.replace and String.prototype.replaceAll interpret
certain sequences such as $$ within a string provided as the
replacement argument. Because of this, LaTeX delimiters $$ were
turning into $, and other sequences could duplicate part of the
existing draft.

Avoid this interpretation by providing a function.

Fixes: zulip#5849
@chrisbobbe chrisbobbe mentioned this issue Apr 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compose: Fix breakage of LaTeX delimiters in quote-and-reply chrisbobbe/zulip-mobile
2 participants
@varkor @chrisbobbe