deps: Use patch-package to fix Xcode build failure in react-native #5709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I forgot a key part of this: updating our postinstall script so |
chrisbobbe
force-pushed
the
pr-patch-package
branch
from
99f7995 to
b2432de
Compare
|
OK, pushed with that fix. |
This gets the effect of facebook/react-native@52d8a797e but without having to upgrade to RN v0.69. I believe this is the first time we've used patch-package. It's a band-aid, but at least I think an effective one, while we focus our time on the Flutter project.
|
Cool, seems best — thanks for working this out. Merging. |
gnprice
force-pushed
the
pr-patch-package
branch
from
b2432de to
b546b07
Compare
|
Thanks! |
|
By the way I tested a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the effect of facebook/react-native@52d8a797e but without having to upgrade to RN v0.69.
I believe this is the first time we've used patch-package. It's a band-aid, but at least I think an effective one, while we focus our time on the Flutter project.