deps: Run yarn upgrade
#5713
Merged
deps: Run yarn upgrade
#5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on my iPhone 13 Pro running iOS 16.4, and on the office Android device (Samsung Galaxy S9 running Android 9); all seems fine. |
gnprice
approved these changes
Apr 3, 2023
package.json
Outdated
| @@ -47,6 +47,7 @@ | |||
| "expo-sqlite": "~10.2.0", | |||
| "expo-web-browser": "~10.2.1", | |||
| "flow-enums-runtime": "^0.0.6", | |||
| "hermes-parser": ">=0.4.8", | |||
There was a problem hiding this comment.
This happens in the commit whose message is just "deps: Run yarn upgrade". I reproduce that yarn upgrade causes this line to get added. Odd.
Presumably related to the hermes-parser line in our resolutions section. Perhaps drop that? At this point our dependencies that pull it in all depend on newer versions than this anyway.
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Apr 4, 2023
We added this because Flow's doc on enabling Flow enums ( https://flow.org/en/docs/enums/enabling-enums/ ) said we should make sure we're using at least version 0.4.8. But that seems to be the case even without the line, so remove it. I'm not sure why now 0.5.0 is brought in, but at least that's later than 0.4.8. Discussion: zulip#5713 (comment)
chrisbobbe
force-pushed
the
pr-yarn-upgrade-2023-04-03
branch
from
cea79c7 to
20b3490
Compare
|
Thanks for the review! Revision pushed. |
For some reason after the upcoming `yarn upgrade`, ESLint would give
these errors:
/Users/chrisbobbe/dev/zulip-mobile/src/boot/TranslationProvider.js
2:49 error
'/Users/chrisbobbe/dev/zulip-mobile/node_modules/react/index.js'
imported multiple times import/no-duplicates
3:57 error
'/Users/chrisbobbe/dev/zulip-mobile/node_modules/react/index.js'
imported multiple times import/no-duplicates
✖ 2 problems (2 errors, 0 warnings)
So prevent those errors by doing this.
5.3.0 says in the changelog that it adds support for the new React Native architecture: https://github.com/react-native-cameraroll/react-native-cameraroll/releases/tag/v5.3.0 We're not yet ready to use the new architecture. Possibly the new architecture doesn't also become *required* at the same time, but we've had similar hopes in comparable situations and it doesn't always work out that way. Plus in 5.3.0 the TypeScript types start importing things with names like TurboModule from the React Native types, and so to support that in our Flow types we'd need changes to TsFlower. Leave that work for later.
We added this because Flow's doc on enabling Flow enums ( https://flow.org/en/docs/enums/enabling-enums/ ) said we should make sure we're using at least version 0.4.8. But that seems to be the case even without the line, so remove it. I'm not sure why now 0.5.0 is brought in, but at least that's later than 0.4.8. Discussion: zulip#5713 (comment)
gnprice
force-pushed
the
pr-yarn-upgrade-2023-04-03
branch
from
20b3490 to
f6d1bc4
Compare
|
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close all our currently open dependabot PRs: https://github.com/zulip/zulip-mobile/pulls/app%2Fdependabot