notifs: Allow token-registration retry from troubleshooting; show server error message #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To see how this param is already passed, look for
applyReducer('session', …)
in src/boot/reducers.js.
gnprice
approved these changes
Apr 24, 2023
src/session/sessionReducer.js
Outdated
| @@ -201,6 +215,36 @@ export default (state: SessionState = initialState, action: Action): SessionStat | |||
| pushToken: action.pushToken, | |||
| }; | |||
|
|
|||
| case REGISTER_PUSH_TOKEN_START: { | |||
| // TODO(#5006: Do for any account, not just the active one | |||
There was a problem hiding this comment.
nit: close-paren (here and below)
No need for a migration; session state isn't persisted.
Now the two enum values TokenNotAcked and TokenUnknown together cover the conditions that were previously covered by just TokenNotAcked, and with no overlap. TokenUnknown will be chosen instead of TokenNotAcked when we haven't yet gotten a token from the platform.
chrisbobbe
force-pushed
the
pr-token-registration-manual-retry
branch
from
90c2d3a to
155c657
Compare
|
Thanks for the review! Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token-registration request (
POST /users/me/apns_device_tokenfor iOS,POST /users/me/android_gcm_reg_idfor Android), like any API request, could fail or sit there forever without succeeding or failing. This PR will make those conditions visible to the client. And when there's a failure, we'll show it to the user, so no one has to go through server logs, and the user can retry.There might be better user-facing text to use, but even if we don't find it, I think this new information and the retry ability are worth it.
To make this screen recording I added this line in my dev server 🙂