ServerCompatBanner: Bump kMinSupportedVersion to 4.10 #5748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r doc With zulip/zulip#26522, the doc at kServerSupportDocUrl -- https://zulip.readthedocs.io/en/latest/overview/release-lifecycle.html#compatibility-and-upgrading -- is updated to no longer give a specific version number, like 4.0. As explained there, that isn't a policy change; the 18-month rule is the policy, and 4.0 was just a value that that policy happened to work out to. So, update this comment to reflect that change of emphasis in the doc.
Before we had a practice of refusing to connect to ancient servers (see kMinAllowedServerVersion), compatibility would break at those ancient versions in idiosyncratic ways, and it made sense to keep track of those ways in a comment like this. Now, instead of dropping ancient-server compatibility in one or another area of the app, we just refuse to connect at all, breaking the user's experience in a uniform and predictable way (along with a prompt to the user to get their server upgraded). So we don't need to keep this list around anymore. (Also, note that 1.8 is well below kMinAllowedServerVersion, so that specific item hasn't been accurate for a while.)
Server 4.9 was released over 18 months ago: https://blog.zulip.com/2022/01/25/zulip-server-4-9-security-release/
gnprice
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server 4.9 was released over 18 months ago:
https://blog.zulip.com/2022/01/25/zulip-server-4-9-security-release/
Also a comment tweak to follow zulip/zulip#26522.