Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corretly serialize and deserialize multiple print areas on one worksheet #17

Merged
merged 3 commits into from
Jul 30, 2023

Conversation

5kahoisaac
Copy link
Contributor

Summary

In order to solve the missing multi print-area in a single sheet of export .xlsx file.

Test plan

Refer to the test plan of the original PR of exceljs (below)

Related to source code (for typings update)

Solution based on: exceljs/exceljs#1516

Corretly serialize and deserialize multiple print areas on one worksheet
@zurmokeeper zurmokeeper self-requested a review July 30, 2023 08:41
@zurmokeeper zurmokeeper self-assigned this Jul 30, 2023
Copy link
Owner

@zurmokeeper zurmokeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

@zurmokeeper zurmokeeper merged commit 8393273 into zurmokeeper:master Jul 30, 2023
@zurmokeeper
Copy link
Owner

@5kahoisaac Merged into master branch for next release

@zurmokeeper zurmokeeper added bug Something isn't working bugfix and removed bug Something isn't working labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants