This repository has been archived by the owner on Jun 2, 2020. It is now read-only.
Fix #4, #6, #9, and probably everything else too #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, hold on. This doesn't work yet for some reason, let me figure out what's going on. |
|
alright, now it works. sorry about that! |
|
Sorry for not responding, I didn't see this until now. Everything looks good, I fixed some other stuff and also made a contributors file that the popup now links to. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue was that the Javascript thought we were on an older browser because
navigator.userAgentwas affected, and therefore applied workarounds that made the actual browser we were actually using confused.This simply tells the JavaScript we're on...well, my current useragent, because I didn't know how to pull the real useragent from a content-script. Probably an easy fix, but I dunno if it's necessary.