Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingest_helper.py to use chardet #2152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kpcrash
Copy link

@kpcrash kpcrash commented Feb 4, 2025

Fixes errors related to character mapping in existing code.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This addresses errors related to charmap exceptions coming from various file types during ingestion.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added code to local repo and tested with list of known failing documents. All documents were successfully uploaded.

  • Added new unit/integration tests
  • I stared at the code and made sure it makes sense

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [X ] My code follows the style guidelines of this project
  • [X ] I have performed a self-review of my code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ X] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [ X] I ran make check; make test to ensure mypy and tests pass

Fixes errors related to character mapping in existing code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant