Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase coverage for ascend and descend scan #114

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

SYaoJun
Copy link
Contributor

@SYaoJun SYaoJun commented Aug 15, 2024

Test ScanAsc and ScanDesc:

  1. If the startKey is in the boundary, the function should return "kNotFound".
  2. If the callback returns false, the function should return "kOK".
  3. If the startKey is found in the B-tree, the function should return the expected count and value.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.75%. Comparing base (3d3b882) to head (29e4793).
Report is 1 commits behind head on main.

Files Patch % Lines
src/btree/BasicKV.cpp 50.00% 0 Missing and 3 partials ⚠️
tests/BasicKVTest.cpp 95.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   62.36%   62.75%   +0.38%     
==========================================
  Files         119      119              
  Lines        8906     8948      +42     
  Branches     3478     3505      +27     
==========================================
+ Hits         5554     5615      +61     
+ Misses       2971     2929      -42     
- Partials      381      404      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/btree/BasicKV.cpp Outdated Show resolved Hide resolved
tests/BasicKVTest.cpp Outdated Show resolved Hide resolved
tests/BasicKVTest.cpp Outdated Show resolved Hide resolved
tests/BasicKVTest.cpp Show resolved Hide resolved
tests/BasicKVTest.cpp Show resolved Hide resolved
tests/BasicKVTest.cpp Outdated Show resolved Hide resolved
Copy link
Owner

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit d69d7dc into zz-jason:main Aug 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants