Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IQueryable.Min and .Max #428

Merged
merged 1 commit into from
Oct 11, 2020

Conversation

gregfullman
Copy link
Contributor

Min and Max extension methods for IQueryable were not available.

@JonathanMagnan JonathanMagnan self-assigned this Oct 9, 2020
@JonathanMagnan
Copy link
Member

Thank you for the pull.

We will look if there is a reason why Min and Max is still not here in the DynamicQueryableExtensions class.

We will look at your pull next week

Best Regards,

Jon


Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework ExtensionsEntity Framework ClassicBulk OperationsDapper Plus

Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval FunctionSQL Eval Function

@StefH
Copy link
Collaborator

StefH commented Oct 9, 2020

This was addressed before #404

@gregfullman
Copy link
Contributor Author

@StefH I did notice #404 - as far as I could tell it specifically addressed the usage of Min/Max nested within a dynamic expression (e.g. the example ion the dotnetfiddle). It didn't account for the extension methods exposed for the IQueryable interface.

@JonathanMagnan JonathanMagnan merged commit b90f412 into zzzprojects:master Oct 11, 2020
@JonathanMagnan
Copy link
Member

Hello @gregfullman ,

The v1.2.3 has been released. I also agree on this addresses a different problem.

@StefH if you believe otherwise, let me know what should be done instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants