Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify/read marker #397

Merged
merged 12 commits into from
Mar 27, 2022
Merged

Modify/read marker #397

merged 12 commits into from
Mar 27, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Feb 25, 2022

This PR contains following changes:

  1. Change ReadMarker fields to ReadSize from ReadCounter
  2. Remove logic that considers previous/latest readmarker

@lpoli lpoli mentioned this pull request Mar 25, 2022
Merged
@lpoli lpoli marked this pull request as ready for review March 27, 2022 14:07
@lpoli lpoli requested review from stewartie4 and dabasov March 27, 2022 14:08
stewartie4
stewartie4 approved these changes Mar 27, 2022
View reviewed changes
Copy link
Contributor

@stewartie4 stewartie4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of

stewartie4
stewartie4 approved these changes Mar 27, 2022
View reviewed changes
Copy link
Contributor

@stewartie4 stewartie4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of

dabasov
dabasov approved these changes Mar 27, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/download-cost-calculation
gosdk modify/read-marker
zboxcli modify/read-marker
zwalletcli staging
0chain modify/read-marker
blobber modify/read-marker2
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@lpoli lpoli merged commit 14b9895 into staging Mar 27, 2022
@cnlangzi cnlangzi deleted the modify/read-marker branch January 3, 2023 00:47
yash10019coder pushed a commit that referenced this pull request Jan 5, 2025
@Kishan-Dhakan
update gosdk to c6ecfb7 (#397)
44e889c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewartie4 stewartie4 stewartie4 approved these changes

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpoli @service-0chain @dabasov @stewartie4