Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify/read marker #201

Merged
merged 10 commits into from
Mar 28, 2022
Merged

Modify/read marker #201

merged 10 commits into from
Mar 28, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Mar 25, 2022

This PR is associated with the readmarker changes.
Check in the blobber PR for the details.

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/download-cost-calculation
gosdk modify/read-marker
zboxcli modify/read-marker
zwalletcli staging
0chain modify/read-marker
blobber modify/read-marker2
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@lpoli lpoli requested review from dabasov and stewartie4 March 27, 2022 15:08
peterlimg
peterlimg approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Please resolve the go modules file conflicts

@lpoli lpoli merged commit 7d324e4 into staging Mar 28, 2022
@Sriep Sriep deleted the modify/read-marker branch August 25, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@dabasov dabasov Awaiting requested review from dabasov

@stewartie4 stewartie4 Awaiting requested review from stewartie4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpoli @service-0chain @peterlimg