Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/revert to readcounter #429

Merged
merged 14 commits into from
Apr 23, 2022
Merged

Fix/revert to readcounter #429

merged 14 commits into from
Apr 23, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Apr 11, 2022 •
edited
Loading

Changes

This PR reverts ReadMarker changes from read size to read counter

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

This was referenced Apr 11, 2022
Merged
Merged
Merged
@lpoli lpoli requested a review from peterlimg April 11, 2022 11:51
@Dmdv Dmdv mentioned this pull request Apr 12, 2022
Closed
peterlimg
peterlimg previously requested changes Apr 12, 2022
View reviewed changes
zboxcore/marker/readmarker.go Outdated Show resolved Hide resolved
@lpoli lpoli requested a review from peterlimg April 13, 2022 00:47
@lpoli lpoli requested review from peterlimg and removed request for peterlimg April 17, 2022 14:32
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/revert-to-readcounter
zboxcli fix/revert-to-readcounter
zwalletcli staging
0chain fix/revert-to-readcounter
blobber fix/revert-to-readcounter
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk fix/revert-to-readcounter
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@lpoli lpoli dismissed peterlimg’s stale review April 23, 2022 15:19

The requested changes has been addressed

@lpoli lpoli merged commit 75736d8 into staging Apr 23, 2022
@lpoli lpoli deleted the fix/revert-to-readcounter branch April 24, 2022 02:52
yash10019coder pushed a commit that referenced this pull request Jan 5, 2025
@stewartie4
enable s3 tests, fix build (#429)
ecd9a92 
* enable s3 tests, fix build

* enable smoke tests

* enable smoke tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

@Sriep Sriep Sriep approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpoli @service-0chain @Sriep @Kishan-Dhakan @peterlimg