Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/revert to readcounter #211

Merged
merged 11 commits into from
Apr 23, 2022
Merged

Fix/revert to readcounter #211

merged 11 commits into from
Apr 23, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Apr 11, 2022 •
edited
Loading

###Changes
This PR reverts Readmarker changes from read size to read counter

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

This was referenced Apr 11, 2022
Merged
Merged
Merged
@lpoli lpoli requested a review from peterlimg April 11, 2022 11:52
peterlimg
peterlimg requested changes Apr 12, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@lpoli lpoli requested a review from peterlimg April 13, 2022 00:47
peterlimg
peterlimg approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix/revert-to-readcounter
zwalletcli staging
0chain fix/revert-to-readcounter
blobber fix/revert-to-readcounter
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/revert-to-readcounter
zboxcli fix/revert-to-readcounter
zwalletcli staging
0chain fix/revert-to-readcounter
blobber fix/revert-to-readcounter
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/revert-to-readcounter
gosdk NOT OVERRIDDEN
zboxcli fix/revert-to-readcounter
zwalletcli staging
0chain fix/revert-to-readcounter
blobber fix/revert-to-readcounter
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/revert-to-readcounter
gosdk NOT OVERRIDDEN
zboxcli fix/revert-to-readcounter
zwalletcli staging
0chain fix/revert-to-readcounter
blobber fix/revert-to-readcounter
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@lpoli lpoli merged commit f5c69d8 into staging Apr 23, 2022
@lpoli lpoli deleted the fix/revert-to-readcounter branch April 24, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpoli @service-0chain @peterlimg @Kishan-Dhakan