Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fix after zboxcli change(s) #592

Merged
merged 3 commits into from
Mar 22, 2023
Merged

minor fix after zboxcli change(s) #592

merged 3 commits into from
Mar 22, 2023

Conversation

SinanEkm
Copy link
Contributor

Changed the TestShareFile/Shared_encrypted_file_to_public_using_auth_ticket_should_fail_to_download case to TestShareFile/Shared_encrypted_file_to_public_using_auth_ticket_should_fail.

Related Zboxcli PR: 0chain/zboxcli#385

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/TestShareFile
gosdk staging
zboxcli 357-for-encrypted-share-clientid-and-encryptionpublickey-should-be-mandatory
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests fix/TestShareFile
gosdk staging
zboxcli 357-for-encrypted-share-clientid-and-encryptionpublickey-should-be-mandatory
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Kishan-Dhakan Kishan-Dhakan merged commit 78e953f into master Mar 22, 2023
@Kishan-Dhakan Kishan-Dhakan deleted the fix/TestShareFile branch March 22, 2023 17:47
peterlimg added a commit that referenced this pull request Mar 24, 2023
@peterlimg
Merge branch 'master' into chain-fee
1ca3393 
# By Kishan Dhakan (1) and others
# Via GitHub
* master:
  fix(upload):download ecnrypted file thumbnail should work (#585)
  skip flaky tests (#598)
  fix responses (#587)
  fix: fixed zwallet API (#595)
  minor fix after zboxcli change(s) (#592)

# Conflicts:
#	go.mod
#	go.sum
#	tests/api_tests/0box_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewartie4 stewartie4 stewartie4 requested changes

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SinanEkm @service-0chain @stewartie4 @Kishan-Dhakan