Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makin clientid and encryptionkey mandatory in encrypted share #385

Conversation

SinanEkm
Copy link
Contributor

A brief description of the changes in this PR:

Related issue: zboxcli#357

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

Sinan Ekmekcibasi and others added 2 commits March 12, 2023 17:21
cmd/share.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clientid should be checked in the if condition too

@SinanEkm
Copy link
Contributor Author

SinanEkm commented Mar 21, 2023

clientid should be checked in the if condition too

I know that but I realized that clientid flag shouldn't be used if it is public share. I tried to use clientid flag by leaving it blank but it didn't work like that, I think clientid flag shouldn't use at all for public share. So, that's why I excluded clientid flag. @Kishan-Dhakan

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/TestShareFile
gosdk staging
zboxcli 357-for-encrypted-share-clientid-and-encryptionpublickey-should-be-mandatory
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests fix/TestShareFile
gosdk staging
zboxcli 357-for-encrypted-share-clientid-and-encryptionpublickey-should-be-mandatory
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Kishan-Dhakan Kishan-Dhakan merged commit 1a4790a into staging Mar 22, 2023
@Kishan-Dhakan Kishan-Dhakan deleted the 357-for-encrypted-share-clientid-and-encryptionpublickey-should-be-mandatory branch March 22, 2023 17:47
peterlimg added a commit that referenced this pull request Mar 26, 2023
* staging:
  fix(path): replaced filepath methods with pathutil for remotepath (#390)
  fix(cost): fixed get-upload-cost and get-download-cost (#387)
  fix(upload): encrypt thumbnail bytes (#386)
  Makin clientid and encryptionkey mandatory in encrypted share (#385)
  Update Readme.md (#391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

for encrypted share, clientid and encryptionpublickey should be mandatory
3 participants