-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makin clientid and encryptionkey mandatory in encrypted share #385
Makin clientid and encryptionkey mandatory in encrypted share #385
Conversation
…yptionpublickey-should-be-mandatory
…yptionpublickey-should-be-mandatory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clientid should be checked in the if condition too
I know that but I realized that clientid flag shouldn't be used if it is public share. I tried to use clientid flag by leaving it blank but it didn't work like that, I think clientid flag shouldn't use at all for public share. So, that's why I excluded clientid flag. @Kishan-Dhakan |
Manual system tests [failure] with the following config
|
Manual system tests [success] with the following config
|
A brief description of the changes in this PR:
Related issue: zboxcli#357
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):