Fix/download cost calculation #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add blockspermarker for the calculation
peterlimg
requested changes
Mar 23, 2022
peterlimg
previously requested changes
Mar 23, 2022
|
Manual system tests [success] with the following config
|
Kishan-Dhakan
dismissed
peterlimg’s stale review
Presuming this review is out of date as @lpoli has merged other related PRs and this needs to be mreged to unblock other developers.
Kishan-Dhakan
approved these changes
Mar 27, 2022
There was a problem hiding this comment.
Approving as @lpoli asked to merge this branch here: https://0chain.slack.com/archives/C02AV6MKT36/p1648395601349229?thread_ts=1648394208.517439&cid=C02AV6MKT36 and this is blocking other Devs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves download cost calculation of
zbox get-download-costandzbox getcommands