fix download accounting test #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpoli
requested review from
stewartie4 and
Kishan-Dhakan
and removed request for
stewartie4
Kishan-Dhakan
approved these changes
Mar 24, 2022
|
Approved on temporary basis, will need to be re-done later. |
|
Happy to approve, assuming calculations are correct |
|
Manual system tests [success] with the following config
|
|
Manual system tests [success] with the following config
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes actual download cost calculation into consideration and tests for the reduced balance.
Related PR:
ZboxCli: 0chain/zboxcli#198
Issue: 0chain/zboxcli#198