Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New simplified User ReadPool related changes #234

Merged
merged 1 commit into from
Jun 6, 2022
Merged

New simplified User ReadPool related changes #234

merged 1 commit into from
Jun 6, 2022

Conversation

iamrz1
Copy link
Contributor

@iamrz1 iamrz1 commented May 19, 2022 •
edited
Loading

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

This was referenced May 19, 2022
Merged
Merged
@iamrz1 iamrz1 force-pushed the user-read-pools branch 2 times, most recently from 4560d18 to 968cb0d Compare May 19, 2022 15:49
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests user-read-pools
gosdk NOT OVERRIDDEN
zboxcli user-read-pools
zwalletcli staging
0chain user-read-pools
blobber user-read-pools
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@iamrz1 iamrz1 force-pushed the user-read-pools branch from 968cb0d to 0627140 Compare May 25, 2022 20:55
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests user-read-pools
gosdk NOT OVERRIDDEN
zboxcli user-read-pools
zwalletcli user-read-pools
0chain user-read-pools
blobber user-read-pools
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli user-read-pools
zwalletcli staging
0chain user-read-pools
blobber user-read-pools
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@iamrz1 iamrz1 force-pushed the user-read-pools branch 2 times, most recently from 8c75d61 to 8e5b600 Compare June 1, 2022 00:57
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests user-read-pools
gosdk NOT OVERRIDDEN
zboxcli user-read-pools
zwalletcli staging
0chain user-read-pools
blobber user-read-pools
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@iamrz1 iamrz1 mentioned this pull request Jun 1, 2022
Merged
3 tasks
dabasov
dabasov approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iamrz1 iamrz1 force-pushed the user-read-pools branch 3 times, most recently from 773a1ca to 6d47de1 Compare June 6, 2022 02:40
@iamrz1 iamrz1 force-pushed the user-read-pools branch from 6d47de1 to 307c4c1 Compare June 6, 2022 06:49
@dabasov dabasov merged commit a819a39 into staging Jun 6, 2022
@cnlangzi cnlangzi deleted the user-read-pools branch February 15, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamrz1 @service-0chain @dabasov