System test fixes for new simplified read-pool #277
Conversation
|
Manual system tests [failure] with the following config
|
|
Manual system tests [failure] with the following config
|
| "tokens": 0.4, | ||
| "duration": "1h", | ||
| }), true) | ||
| output, err = readPoolLock(t, configPath, "--tokens 0.4", true) |
There was a problem hiding this comment.
The createParams logic above is consistent with the rest of the test codebase, why has it been removed in favour of literal strings?
There was a problem hiding this comment.
according to my testing, boolean flag doesn't work with parameter map, and read pool lock command has boolean flag. hence all the call to lock read-pool has been changed to look similar in case we need to use the parameter more in the future.
There was a problem hiding this comment.
you can pass through a boolean with
output, err = readPoolLock(t, configPath, createParams(map[string]interface{}{
"booleanName": "",
}), true)
or
output, err = readPoolLock(t, configPath, createParams(map[string]interface{}{
"booleanName": "true",
}), true)
There was a problem hiding this comment.
see how we do it for the commit flag for example
https://github.com/0chain/system_test/pull/282/files#diff-b64b1f0b1e26c3819b06b4df6e3961b113082b9e744f7b4ea499371cf8459c89R60
There was a problem hiding this comment.
this would work with bool values that assume the default value to be false. I have added a fix in createParams that would work with boolean values directly, so we don't have to use blank string for false values.
Also reversed all the strings back to params using createParams.
PTAL.
|
Manual system tests [success] with the following config
|
No description provided.