Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gosdk to specific commit #328

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Upgrade gosdk to specific commit #328

merged 5 commits into from
Nov 21, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Nov 20, 2022

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@lpoli lpoli requested review from dabasov and peterlimg November 20, 2022 06:27
@lpoli lpoli mentioned this pull request Nov 20, 2022
Merged
3 tasks
@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests add-download-coverage
gosdk fix/download-issue
zboxcli fix/download-issue
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

dabasov
dabasov approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests add-download-coverage
gosdk fix/download-issue
zboxcli fix/download-issue
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests add-download-coverage
gosdk fix/download-issue
zboxcli fix/download-issue
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Kishan-Dhakan Kishan-Dhakan merged commit 8b23668 into staging Nov 21, 2022
@Kishan-Dhakan Kishan-Dhakan deleted the fix/download-issue branch November 21, 2022 22:22
@cnlangzi cnlangzi mentioned this pull request Mar 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpoli @service-0chain @dabasov @Kishan-Dhakan