Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(createdir): fixed context issue #380

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Mar 8, 2023

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest commit id is b2f79bf02c5b47375f97ad257334c13a08bc806e, please update it. thanks.

@cnlangzi
Copy link
Contributor

cnlangzi commented Mar 9, 2023

@lpoli Could you list related PRs in Associated PRs (Link as appropriate) section in future? It is easier for reviewer to know why gosdk should be upgraded, and which commit id is latest. There are many PRs labelled with Upgrade gosdk to specific commit from you. They are confused.

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk staging
zboxcli fix/lock-with-context-issue
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@lpoli
Copy link
Contributor Author

lpoli commented Mar 9, 2023

@lpoli Could you list related PRs in Associated PRs (Link as appropriate) section in future? It is easier for reviewer to know why gosdk should be upgraded, and which commit id is latest. There are many PRs labelled with Upgrade gosdk to specific commit from you. They are confused.

* [Upgrade gosdk to specific commit #343](https://github.com/0chain/zboxcli/pull/343)

* [Upgrade gosdk to specific commit #380](https://github.com/0chain/zboxcli/pull/380)

* [Upgrage gosdk to specific commit #375](https://github.com/0chain/zboxcli/pull/375)

* [Upgrade gosdk #378](https://github.com/0chain/zboxcli/pull/378)

* [Upgrade gosdk to specific commit #328](https://github.com/0chain/zboxcli/pull/328)

* [Upgrade gosdk to specific commit #322](https://github.com/0chain/zboxcli/pull/322)

* .....

We can check with the given commit id.
I see your point though. I will link from next time.
Thanks

@lpoli lpoli requested a review from cnlangzi March 9, 2023 04:21
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi changed the title Upgrade gosdk to specific commit fix(createdir): fixed context issue Mar 9, 2023
@lpoli lpoli merged commit a11c037 into staging Mar 9, 2023
@lpoli lpoli deleted the fix/lock-with-context-issue branch March 9, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants